fix(konnect): do not create Service+Route combinations for konghq.com/plugins annotated entities
#659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
pmalek
force-pushed
the
konnect-plugin-annotations-dont-create-sr-combinations
branch
from
8374bba to
badc8a7
Compare
6 tasks
pmalek
force-pushed
the
konnect-plugin-annotations-dont-create-sr-combinations
branch
from
badc8a7 to
ec2db44
Compare
czeslavo
approved these changes
Sep 27, 2024
…/plugins annotated entities
pmalek
force-pushed
the
konnect-plugin-annotations-dont-create-sr-combinations
branch
from
ec2db44 to
2d9cd71
Compare
pmalek
deleted the
konnect-plugin-annotations-dont-create-sr-combinations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#644 introduced creation of
KongPluginBindings based onkonghq.com/pluginsannotations on entities that can have plugins bound (for this specific PR Services and Routes have received support).In order to do so, the operator needs to generate combinations of objects that should be set as targets of a plugin.
This in the operator is achieved using
KongPluginBinding.If a plugin annotation is set on a KongRoute r1 and KongService s1 operator has 3 options to create the binding:
KongRouteand 1 forKongServiceKongRouteandKongService, and 1 forKongServiceKongRouteandKongServiceKIC uses the 1st approach backed by a UT in here.
This PR changes the behavior that has been introduced by #644 from 3 to 1 ( to align with KIC ).
Further discussion on this topic can take place in #660